Messages in this thread Patch in this message | | | Subject | Re: [PATCH] Migration of standard timers | From | Jes Sorensen <> | Date | 14 Sep 2006 10:11:39 -0400 |
| |
>>>>> "Dimitri" == Dimitri Sivanich <sivanich@sgi.com> writes:
Dimitri> This patch allows the user to migrate currently queued Dimitri> standard timers from one cpu to another, thereby reducing Dimitri> timer induced latency on the chosen cpu. Timers that were Dimitri> placed with add_timer_on() are considered to have 'cpu Dimitri> affinity' and are not moved.
Dimitri> The changes in drivers/base/cpu.c provide a clean and Dimitri> convenient interface for triggering the migration through Dimitri> sysfs, via writing the destination cpu number to a file Dimitri> associated with the source cpu.
Hi Dimitri,
I just took a quick look at your patch, and at least on the surface it looks pretty nice to me.
One minor nit, why choose short for the affinity field in struct timer_list, it seems a strange size to pick for something which is either 0 or 1. Wouldn't int or char be better? I don't know if all CPUs have 16 bit stores, but they should have 8 and 32 bit.
The name 'aff' for affinity might not be good either, since we tend to refer to affinity as a mask specifying where it's locked to, maybe 'locked' would be better?
All in the nit-picking department though.
Cheers, Jes
Index: linux/include/linux/timer.h =================================================================== --- linux.orig/include/linux/timer.h +++ linux/include/linux/timer.h @@ -15,6 +15,8 @@ struct timer_list { unsigned long data; struct tvec_t_base_s *base; + + short aff; }; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |