lkml.org 
[lkml]   [2006]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/12] thinkpad_ec: New driver for ThinkPad embedded controller access
On 2006.08.07 19:41:11 +0300, Shem Multinymous wrote:
> On 8/7/06, Björn Steinbrink <B.Steinbrink@gmx.de> wrote:
> >On 2006.08.07 18:13:06 +0300, Shem Multinymous wrote:
> >> >> + struct dmi_device *dev = NULL;
> >> >unneeded initializer.
> >> On a local variable?!
> >
> >You assign a new value to it on the next line, without ever using its
> >initial value.
>
> The initial value is used in the last parameter to dmi_find_device():
>
> struct dmi_device *dev = NULL;
> while ((dev = dmi_find_device(type, NULL, dev))) {
> if (strstr(dev->name, substr))
> return 1;
> }

Sorry, somehow my brain skipped the end of the line.

Björn
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-07 18:57    [W:0.185 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site