Messages in this thread | | | Date | Mon, 7 Aug 2006 19:41:11 +0300 | From | "Shem Multinymous" <> | Subject | Re: [PATCH 01/12] thinkpad_ec: New driver for ThinkPad embedded controller access |
| |
On 8/7/06, Björn Steinbrink <B.Steinbrink@gmx.de> wrote: > On 2006.08.07 18:13:06 +0300, Shem Multinymous wrote: > > >> + struct dmi_device *dev = NULL; > > >unneeded initializer. > > On a local variable?! > > You assign a new value to it on the next line, without ever using its > initial value.
The initial value is used in the last parameter to dmi_find_device():
struct dmi_device *dev = NULL; while ((dev = dmi_find_device(type, NULL, dev))) { if (strstr(dev->name, substr)) return 1; }
Shem - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |