Messages in this thread Patch in this message | | | Date | Wed, 2 Aug 2006 01:20:24 +0800 | From | kenny <> | Subject | [Patch] kernel: bug fixing for kernel/kmod.c |
| |
I think there is a bug in kmod.c. In __call_usermodehelper(), when kernel_thread(wait_for_helper, ...) return success, since wait_for_helper() might call complete() at any time, the sub_info should not be used any more.
the following patch is made in 2.6.17.7
--- kmod.c 2006-07-25 11:36:01.000000000 +0800 +++ /tmp/kmod.c 2006-08-02 01:01:42.702054000 +0800 @@ -198,6 +198,7 @@ static void __call_usermodehelper(void * { struct subprocess_info *sub_info = data; pid_t pid; + int wait = sub_info->wait;
/* CLONE_VFORK: wait until the usermode helper has execve'd * successfully We need the data structures to stay around @@ -212,7 +213,7 @@ static void __call_usermodehelper(void * if (pid < 0) { sub_info->retval = pid; complete(sub_info->complete); - } else if (!sub_info->wait) + } else if (!wait) complete(sub_info->complete); }
-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |