lkml.org 
[lkml]   [2006]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH-2.4] EXT3: ext3 block bitmap leakage
Hi Marcelo,

we missed this patch sent by Kirill Korotaev on LKML. Fortunately, Roberto
noticed it and forwarded it to me.

Since it's been there for a very long time, there's no emergency, but the
problem looks real and the fix seems to be confirmed, so if you have not
closed 2.4.33 yet, it might be worth merging it too.

Here it is as a git patch, but I've queued it in -upstream if you prefer.

Cheers,
Willy


From nobody Mon Sep 17 00:00:00 2001
From: Kirill Korotaev <dev@openvz.org>
Date: Fri, 30 Jun 2006 13:41:05 +0400
Subject: [PATCH] EXT3: ext3 block bitmap leakage

This patch fixes ext3 block bitmap leakage,
which leads to the following fsck messages on
_healthy_ filesystem:
Block bitmap differences: -64159 -73707

All kernels up to 2.6.17 have this bug.

Found by
Vasily Averin <vvs@sw.ru> and Andrey Savochkin <saw@sawoct.com>
Test case triggered the issue was created by
Dmitry Monakhov <dmonakhov@sw.ru>

Signed-Off-By: Vasiliy Averin <vvs@sw.ru>
Signed-Off-By: Andrey Savochkin <saw@sawoct.com>
Signed-Off-By: Kirill Korotaev <dev@openvz.org>
CC: Dmitry Monakhov <dmonakhov@sw.ru>

---

fs/ext3/inode.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

8c6f6cf38bc9b04edc69c2869ae1e6c584584b4f
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index bcd86f6..d8f5a9b 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -570,6 +570,7 @@ static int ext3_alloc_branch(handle_t *h

branch[0].key = cpu_to_le32(parent);
if (parent) {
+ keys = 1;
for (n = 1; n < num; n++) {
struct buffer_head *bh;
/* Allocate the next block */
--
1.3.3
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-02 01:32    [W:0.025 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site