Messages in this thread Patch in this message | | | Date | Wed, 31 May 2006 22:02:36 +0200 | From | Ingo Molnar <> | Subject | [patch, -rc5-mm1] locking validator: special rule: 8390.c disable_irq() |
| |
untested on 8390 hardware, but ought to solve the lockdep false positive.
----------------- Subject: locking validator: special rule: 8390.c disable_irq() From: Ingo Molnar <mingo@elte.hu>
8390.c knows that ei_local->page_lock can only be used by an irq context that it disabled - and can hence take the ->page_lock without disabling hardirqs. Teach lockdep about this.
Signed-off-by: Ingo Molnar <mingo@elte.hu> --- drivers/net/8390.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux/drivers/net/8390.c =================================================================== --- linux.orig/drivers/net/8390.c +++ linux/drivers/net/8390.c @@ -249,7 +249,7 @@ void ei_tx_timeout(struct net_device *de /* Ugly but a reset can be slow, yet must be protected */ - disable_irq_nosync(dev->irq); + disable_irq_nosync_lockdep(dev->irq); spin_lock(&ei_local->page_lock); /* Try to restart the card. Perhaps the user has fixed something. */ @@ -257,7 +257,7 @@ void ei_tx_timeout(struct net_device *de NS8390_init(dev, 1); spin_unlock(&ei_local->page_lock); - enable_irq(dev->irq); + enable_irq_lockdep(dev->irq); netif_wake_queue(dev); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |