Messages in this thread | | | Date | Sun, 14 May 2006 10:12:54 -0700 | From | "Randy.Dunlap" <> | Subject | Re: [patch] Cleanups to Doc*/SubmittingPatches |
| |
On Sun, 14 May 2006 16:30:38 +0200 Pavel Machek wrote:
> This cleans up Submitting patches a bit. Missing/inconsistent full > stops, mostly.
Incomplete sentences (fragments) don't need full stops, but they should be consistent.
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches > index c2c85bc..07b87ce 100644 > --- a/Documentation/SubmittingPatches > +++ b/Documentation/SubmittingPatches > @@ -173,17 +173,17 @@ copy the maintainer when you change thei > For small patches you may want to CC the Trivial Patch Monkey > trivial@kernel.org managed by Adrian Bunk; which collects "trivial" > patches. Trivial patches must qualify for one of the following rules: > - Spelling fixes in documentation > + Spelling fixes in documentation. > Spelling fixes which could break grep(1).
I would just remove that '.' above and skip the rest of the changes in this section.
> - Warning fixes (cluttering with useless warnings is bad) > - Compilation fixes (only if they are actually correct) > - Runtime fixes (only if they actually fix things) > + Warning fixes (cluttering with useless warnings is bad). > + Compilation fixes (only if they are actually correct). > + Runtime fixes (only if they actually fix things). > Removing use of deprecated functions/macros (eg. check_region). > - Contact detail and documentation fixes > + Contact detail and documentation fixes. > Non-portable code replaced by portable code (even in arch-specific, > - since people copy, as long as it's trivial) > - Any fix by the author/maintainer of the file. (ie. patch monkey > - in re-transmission mode) > + since people copy, as long as it's trivial). > + Any fix by the author/maintainer of the file (ie. patch monkey > + in re-transmission mode). > URL: <http://www.kernel.org/pub/linux/kernel/people/bunk/trivial/>
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |