lkml.org 
[lkml]   [2006]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH -mm] updated megaraid gcc 4.1 warning fix
Date
From
Hi,
Wednesday, May 10, 2006 1:27 PM, Daniel Walker wrote:
> drivers/scsi/megaraid.c: In function âEUR~megadev_ioctlâEUR(tm):
> drivers/scsi/megaraid.c:3665: warning: ignoring return value
> of âEUR~copy_to_userâEUR(tm), declared with attribute warn_unused_result
Thank you for the patch.
I accept the patch.

> -----Original Message-----
> From: Daniel Walker [mailto:dwalker@mvista.com]
> Sent: Wednesday, May 10, 2006 1:27 PM
> To: akpm@osdl.org
> Cc: Ju, Seokmann; alan@lxorguk.ukuu.org.uk;
> linux-kernel@vger.kernel.org
> Subject: [PATCH -mm] updated megaraid gcc 4.1 warning fix
>
> Hows that Alan?
>
> Fixes the following warning,
>
> drivers/scsi/megaraid.c: In function âEUR~megadev_ioctlâEUR(tm):
> drivers/scsi/megaraid.c:3665: warning: ignoring return value
> of âEUR~copy_to_userâEUR(tm), declared with attribute warn_unused_result
>
> Signed-Off-By: Daniel Walker <dwalker@mvista.com>
>
> Index: linux-2.6.16/drivers/scsi/megaraid.c
> ===================================================================
> --- linux-2.6.16.orig/drivers/scsi/megaraid.c
> +++ linux-2.6.16/drivers/scsi/megaraid.c
> @@ -3662,8 +3662,9 @@ megadev_ioctl(struct inode *inode, struc
> * Send the request sense data also,
> irrespective of
> * whether the user has asked for it or not.
> */
> - copy_to_user(upthru->reqsensearea,
> - pthru->reqsensearea, 14);
> + if (copy_to_user(upthru->reqsensearea,
> + pthru->reqsensearea, 14))
> + rval = (-EFAULT);
>
> freemem_and_return:
> if( pthru->dataxferlen ) {
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-11 15:20    [W:0.067 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site