Messages in this thread Patch in this message | | | Subject | [Patch] Possible double free in net/bluetooth/sco.c | From | Eric Sesterhenn <> | Date | Tue, 04 Apr 2006 21:25:18 +0200 |
| |
hi,
this fixes coverity bug id #1068. hci_send_sco() frees skb if (skb->len > hdev->sco_mtu). Since it returns a negative error value only in this case, we can directly return here.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.17-rc1/net/bluetooth/sco.c.orig 2006-04-04 21:19:51.000000000 +0200 +++ linux-2.6.17-rc1/net/bluetooth/sco.c 2006-04-04 21:20:34.000000000 +0200 @@ -255,7 +255,7 @@ static inline int sco_send_frame(struct } if ((err = hci_send_sco(conn->hcon, skb)) < 0) - goto fail; + return err; return count;
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |