Messages in this thread | | | Subject | RE: Problems with EDAC coexisting with BIOS | Date | Tue, 25 Apr 2006 20:19:51 -0700 | From | "Gross, Mark" <> |
| |
>-----Original Message----- >From: Corey Minyard [mailto:minyard@acm.org] >Sent: Tuesday, April 25, 2006 7:19 PM >To: Gross, Mark >Cc: Alan Cox; bluesmoke-devel@lists.sourceforge.net; LKML; Carbonari, >Steven; Ong, Soo Keong; Wang, Zhenyu Z >Subject: Re: Problems with EDAC coexisting with BIOS > >Gross, Mark wrote: > >>>Yes, this is what I was talking about. I believe the mode of >>>module_param should be 444, since modifying this after the module is >>>loaded won't do anything. Also, it might be nice to print something >>>different in the "force" case. >>> >>> >> >>How about printing nothing like it used too? >> >>See attached. >> >> >This is fine with me. I debated between printing nothing and a "You >have chosen to override ..." print but didn't come out with any >opinion. I'm easy either way. > >The indenting in the "if (!force_function_unhide && !(stat8 & (1 << 5))) >{" clause is kind of strange
I know I'm going to regret this but: What's strange about it?
> and you have some spaces instead of tabs >right after that (where stat8 is set).
Damn. I pasted using the x-windows middle mouse button :( I'll redo the patch when I get back to my workstation tomorrow.
--mgross - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |