Messages in this thread Patch in this message | | | Date | Mon, 24 Apr 2006 16:36:49 +0800 | From | Akinobu Mita <> | Subject | [PATCH] use hlist_unhashed() |
| |
Use hlist_unhashed() rather than accessing inside data structure.
Signed-off-by: Akinobu Mita <mita@miraclelinux.com> CC: "David S. Miller" <davem@davemloft.net>
include/linux/list.h | 2 +- include/net/inet_timewait_sock.h | 2 +- include/net/sock.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
Index: 2.6-git/include/net/inet_timewait_sock.h =================================================================== --- 2.6-git.orig/include/net/inet_timewait_sock.h +++ 2.6-git/include/net/inet_timewait_sock.h @@ -150,7 +150,7 @@ static inline void inet_twsk_add_bind_no static inline int inet_twsk_dead_hashed(const struct inet_timewait_sock *tw) { - return tw->tw_death_node.pprev != NULL; + return !hlist_unhashed(&tw->tw_death_node); } static inline void inet_twsk_dead_node_init(struct inet_timewait_sock *tw) Index: 2.6-git/include/net/sock.h =================================================================== --- 2.6-git.orig/include/net/sock.h +++ 2.6-git/include/net/sock.h @@ -279,7 +279,7 @@ static inline int sk_unhashed(const stru static inline int sk_hashed(const struct sock *sk) { - return sk->sk_node.pprev != NULL; + return !sk_unhashed(sk); } static __inline__ void sk_node_init(struct hlist_node *node) Index: 2.6-git/include/linux/list.h =================================================================== --- 2.6-git.orig/include/linux/list.h +++ 2.6-git/include/linux/list.h @@ -619,7 +619,7 @@ static inline void hlist_del_rcu(struct static inline void hlist_del_init(struct hlist_node *n) { - if (n->pprev) { + if (!hlist_unhashed(n)) { __hlist_del(n); INIT_HLIST_NODE(n); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |