Messages in this thread | | | Date | Mon, 10 Apr 2006 12:00:59 +0200 | From | Hannes Reinecke <> | Subject | Re: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text |
| |
Stefan Richter wrote: > Rolf Eike Beer wrote: >> Denis Vlasenko wrote: >>> I am leaving it up to maintainer to decide. After all, the driver >>> is for multiple OSes, other OS may lack mdelay(). >> The comment says about multiple milliseconds sleeps which just don't happen. > > Given what ah{c,d}_delay are (OS dependent wrappers) and how they are > used (definitely not for multi-msec delays), they should just be changed > into a #define ah{c,d}_delay(us) udelay(us) or into void inline > ah{c,d}_delay(long us) {udelay(us);}.
I'd rather do a #define. Inlining simple functions is quite unneccessary here.
Re multiplatform development: aic7{9,x}xx have ceased to be multiplatfrom since the integration of scsi_transport_spi. So I wouldn't worry too much about it.
Cheers,
Hannes -- Dr. Hannes Reinecke hare@suse.de SuSE Linux Products GmbH S390 & zSeries Maxfeldstraße 5 +49 911 74053 688 90409 Nürnberg http://www.suse.de - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |