lkml.org 
[lkml]   [2006]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text
    Date
    [Full quote and readded CC adresses. My fault, pressed wrong button]

    Denis Vlasenko wrote:
    > On Monday 10 April 2006 10:03, Rolf Eike Beer wrote:
    > > Am Montag, 10. April 2006 07:49 schrieben Sie:
    > > > On Monday 10 April 2006 08:44, Denis Vlasenko wrote:
    > > > > I also spotted two bugs in the process, patches
    > > > > for those will follow.
    > > >
    > > > ahd_delay(usec) is buggy. Just think how would it work
    > > > with usec == 1024*100 + 1...
    > >
    > > This is unneeded. The biggest argument this function is ever called with
    > > is 1000.
    >
    > I know.
    >
    > > I would suggest to delete this function completely. If one ever has to
    > > wait for a longer period mdelay() is the right function to call.
    >
    > I am leaving it up to maintainer to decide. After all, the driver
    > is for multiple OSes, other OS may lack mdelay().

    The comment says about multiple milliseconds sleeps which just don't happen.

    Eike
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2006-04-10 09:26    [W:4.264 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site