Messages in this thread Patch in this message | | | Date | Wed, 22 Mar 2006 16:25:00 +0100 | From | Martin Schwidefsky <> | Subject | [patch 18/24] s390: tape operation abortion leads to panic |
| |
From: Michael Holzheu <holzheu@de.ibm.com>
[patch 18/24] s390: tape operation abortion leads to panic
When a request is aborted because of a signal, we currently stop the request via csh, but we do not wait for the interrupt of csh in any case. We free the request structure and therefore when the interrupt for the csh operation is presented, the request object is no longer valid and an invalid callback pointer is used. To fix this wait until the interrupt for csh arrives and until wait_event_interruptible() does not return -ERESTARTSYS.
Signed-off-by: Michael Holzheu <holzheu@de.ibm.com> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com> ---
drivers/s390/char/tape_core.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)
diff -urpN linux-2.6/drivers/s390/char/tape_core.c linux-2.6-patched/drivers/s390/char/tape_core.c --- linux-2.6/drivers/s390/char/tape_core.c 2006-03-22 14:36:33.000000000 +0100 +++ linux-2.6-patched/drivers/s390/char/tape_core.c 2006-03-22 14:36:33.000000000 +0100 @@ -1015,7 +1015,7 @@ tape_do_io_interruptible(struct tape_dev wq, (request->callback == NULL) ); - } while (rc != -ERESTARTSYS); + } while (rc == -ERESTARTSYS); DBF_EVENT(3, "IO stopped on %08x\n", device->cdev_id); rc = -ERESTARTSYS; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |