Messages in this thread Patch in this message | | | Date | Mon, 20 Mar 2006 22:09:31 +0100 (MET) | From | Jan Engelhardt <> | Subject | Parenthesize macros in xfs |
| |
Hello xfs list,
while browsing through the xfs/linux source, I noticed that many macros do not do proper bracing. I have started to cook up a patch, but would like feedback first before I continue for nothing. It goes like this:
diff --fast -dpru linux-2.6.16~/fs/xfs/xfs_acl.h linux-2.6.16/fs/xfs/xfs_acl.h --- linux-2.6.16~/fs/xfs/xfs_acl.h 2006-03-20 06:53:29.000000000 +0100 +++ linux-2.6.16/fs/xfs/xfs_acl.h 2006-03-20 21:23:02.235418000 +0100 @@ -55,7 +55,7 @@ struct xfs_inode;
extern struct kmem_zone *xfs_acl_zone; #define xfs_acl_zone_init(zone, name) \ - (zone) = kmem_zone_init(sizeof(xfs_acl_t), name) + (zone) = kmem_zone_init(sizeof(xfs_acl_t), (name)) #define xfs_acl_zone_destroy(zone) kmem_cache_destroy(zone)
extern int xfs_acl_inherit(struct vnode *, struct vattr *, xfs_acl_t *);
Jan Engelhardt -- | Software Engineer and Linux/Unix Network Administrator - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |