lkml.org 
[lkml]   [2006]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/2] Validate itimer timeval from userspace

* Thomas Gleixner <tglx@linutronix.de> wrote:

> According to the specification the timeval must be validated and an
> errorcode -EINVAL returned in case the timeval is not in canonical
> form. Before the hrtimer merge this was silently ignored by the
> timeval to jiffies conversion. The validation is done inside
> do_setitimer so all callers are catched.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

ok - bad (invalid) timevals were thus randomly interpreted? I agree that
even though this is new behavior, it is much better to return -EINVAL
than to behave randomly. OTOH, since 2.6.15 and earlier did this too, is
there any urgency to apply this to 2.6.16?

Acked-by: Ingo Molnar <mingo@elte.hu>

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-18 20:19    [W:0.131 / U:1.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site