Messages in this thread | | | Subject | Re: [patch 1/2] Validate itimer timeval from userspace | From | Thomas Gleixner <> | Date | Sat, 18 Mar 2006 21:30:20 +0100 |
| |
On Sat, 2006-03-18 at 21:23 +0100, Jesper Juhl wrote:
> Wouldn't this only break existing applications that do incorrect > things (passing invalid values) ? > If that's the case I'd say breaking them is OK and we should change to > follow the spec. > > I don't like potential userspace breakage any more than the next guy, > but if the breakage only affects buggy applications then I think it's > more acceptable.
Yes, it only breaks buggy applications.
On a full blown desktop the check (I added a printk) did not trigger.
The only application I found so far was the LTP setitimer "correctness" test, which did not initialize it_interval and handed random garbage to the kernel. :)
tglx
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |