Messages in this thread | | | Date | Mon, 27 Feb 2006 14:13:16 +0000 | From | Pavel Machek <> | Subject | Re: [PATCH] Convert serial_core oopses to BUG_ON |
| |
On Sun 26-02-06 02:14:14, Andrew Morton wrote: > Russell King <rmk+lkml@arm.linux.org.uk> wrote: > > > > Calling serial functions to flush buffers, or try to send more data > > after the port has been closed or hung up is a bug in the code doing > > the calling, not in the serial_core driver. > > > > Make this explicitly obvious by adding BUG_ON()'s. > > If we make it > > if (!info) { > WARN_ON(1); > return; > } > > will that allow people's kernels to limp along until it gets fixed?
It will oops in hard-to-guess, place, anyway. BUG_ON is right. -- Thanks, Sharp! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |