Messages in this thread | | | Date | Sun, 26 Feb 2006 18:17:47 +0000 | From | Russell King <> | Subject | Re: [PATCH] Convert serial_core oopses to BUG_ON |
| |
On Sun, Feb 26, 2006 at 02:14:14AM -0800, Andrew Morton wrote: > Russell King <rmk+lkml@arm.linux.org.uk> wrote: > > > > Calling serial functions to flush buffers, or try to send more data > > after the port has been closed or hung up is a bug in the code doing > > the calling, not in the serial_core driver. > > > > Make this explicitly obvious by adding BUG_ON()'s. > > If we make it > > if (!info) { > WARN_ON(1); > return; > } > > will that allow people's kernels to limp along until it gets fixed?
"until" - I think you mean "if anyone ever bothers" so no I don't agree. The bluetooth folk seem to have absolutely no interest in bug fixing. Can we mark bluetooth broken please?
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |