lkml.org 
[lkml]   [2006]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: LibPATA code issues / 2.6.15.4
Linus Torvalds wrote:
>
> On Mon, 27 Feb 2006, Jeff Garzik wrote:
>
>>I've had this waiting in the wings, in fact... [see attached]
>
>
> I really hate having a _global_ variable called "fua". That's just bad
> taste. I would suggest calling it "atapi_forced_unit_attention_enabled",
> but maybe that is going a bit overboard. It's definitely better than just
> "fua", though.

<shrug> It will go away when things are fixed, and only users who are
testing will even bother with it.

Looking over the module subsystem, it looks like one could use
module_param_named() to achieve proper namespace separation (C versus
module opt) -- then you could call it libata_fua -- but for a temporary
module option it seems like more trouble than its worth.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-28 03:55    [W:0.208 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site