Messages in this thread Patch in this message | | | Date | Mon, 27 Feb 2006 10:24:05 -0500 (EST) | From | Steven Rostedt <> | Subject | [PATCH -rt] buggy UART fix |
| |
Ingo,
I'm not sure if this is the correct fix, but it fixes a problem on one of our boards. The uart does't set the IIR register upon receiving an interrupt for transmit. Thus we get processes stuck waiting to send data out.
This doesn't seem to be a problem on vanilla, and I'm not sure why. Perhaps the scheduling doesn't ever let the transmit buffer get full? Well I haven't look too much into the vanilla side.
This patch forces the processing of the interrupt even if the iir doesn't show that there was an interrupt, iff the uart has been detected as buggy (which our board's uart is ) and the interrupt hasn't already handled it.
-- Steve
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Index: linux-2.6.15-rt17/drivers/serial/8250.c =================================================================== --- linux-2.6.15-rt17.orig/drivers/serial/8250.c 2006-02-27 10:20:31.000000000 -0500 +++ linux-2.6.15-rt17/drivers/serial/8250.c 2006-02-27 10:20:53.000000000 -0500 @@ -1344,6 +1344,17 @@ static irqreturn_t serial8250_interrupt( "irq%d\n", irq); break; } + /* + * If we have a buggy TX line, that doesn't + * notify us via iir that we need to transmit + * then force the call. + */ + if (!handled && (up->bugs & UART_BUG_TXEN)) { + spin_lock(&up->port.lock); + serial8250_handle_port(up, regs); + spin_unlock(&up->port.lock); + } + } while (l != end);
spin_unlock(&i->lock); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |