Messages in this thread | | | Date | Wed, 22 Feb 2006 12:47:15 -0600 | From | Corey Minyard <> | Subject | Problem with NETIF_F_HIGHDMA |
| |
I was looking at a problem with a new system we are trying to get up and running. It has a 32-bit only PCI network device, but is a 64-bit (x86_64) system. Looking at the code for NETIF_F_HIGHDMA (which, when not set on a PCI network device, means that it cannot do 64-bit accesses) in net/core/dev.c, it seems wrong to me.
It is dependent on HIGHMEM, but HIGHMEM has nothing to do with 32/64 bit accesses. On 64-bit systems, HIGHMEM is not set, thus the network code will pass any address (including those >32bits) to the driver. Plus, highmem on 32-bit systems may very well be 32-bit accessible, possibly resulting in unecessary copies. AFAICT, the current code will only work with i386 and PAE and is sub-optimal.
If I am right, it is a little messy to fix, but I think doable. I propose the following:
* Create a new zone named ZONE_HIGHMEM32 for 32-bit HIGHMEM addresses. * Modify 64-bit architectures (and i386 with HIGHMEM) to put the proper pages into the new zone. * Add a "PageIn32Bits()" function/macro to check for this, and use it in illegal_highdma() in net/core/dev.c * Allocate from ZONE_HIGHMEM32 if illegal_highdma() returns true.
I think this will solve the problem. I haven't looked at other parts of the kernel (IDE, SCSI, etc.) to see if they have similar problems.
Anyway, does the above change sound reasonable? Maybe there's an easier way? Maybe I've missed something?
Thanks,
-Corey - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |