Messages in this thread | | | Subject | RE: [PATCH 1/1] EFI iounpam fix for acpi_os_unmap_memory take two | Date | Tue, 21 Feb 2006 09:26:37 +0800 | From | "Li, Shaohua" <> |
| |
Hi, > >When EFI is enabled acpi_os_unmap_memory trys to unmap memory >which was not mapped by acpi_os_map_memory. Yes, this could solve you problem at hand, but I wonder why we should always use ioremap in acpi_os_map_memory. It's ACPI tables or pci memory bar, ioremap should be safe to me.
Thanks, Shaohua
> >Signed-off-by: Edgar Hucek <hostmaster@ed-soft.at> > >diff -uNr linux-2.6.16-rc4.orig/drivers/acpi/osl.c linux-2.6.16- >rc4/drivers/acpi/osl.c >--- linux-2.6.16-rc4.orig/drivers/acpi/osl.c 2006-02-19 >18:48:58.000000000 +0100 >+++ linux-2.6.16-rc4/drivers/acpi/osl.c 2006-02-20 15:31:44.000000000 +0100 >@@ -208,7 +208,13 @@ > > void acpi_os_unmap_memory(void __iomem * virt, acpi_size size) > { >- iounmap(virt); >+ if(efi_enabled) { >+ if (!(EFI_MEMORY_WB & >efi_mem_attributes(virt_to_phys(virt)))) { >+ iounmap(virt); >+ } >+ } else { >+ iounmap(virt); >+ } > } > EXPORT_SYMBOL_GPL(acpi_os_unmap_memory);
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |