Messages in this thread | | | Subject | Re: [PATCH 5/6] x25: Allow 32 bit socket ioctl in 64 bit kernel | From | Shaun Pereira <> | Date | Thu, 16 Feb 2006 16:40:26 +1100 |
| |
Thanks for that Aranaldo
I have corrected this so as to be compliant with OSI Network services for DTE facilities and rebuilt and retested the patches Corrected patches follow.
On Wed, 2006-02-15 at 20:35 -0200, Arnaldo Carvalho de Melo wrote: > On 2/15/06, Shaun Pereira <spereira@tusc.com.au> wrote: > > > + switch (*p) { > > + case X25_FAC_CALLING_AE: > > + if (p[1] > 33) > > + break; > > + dte_facs->calling_len = p[2]; > > + memcpy(dte_facs->calling_ae, &p[3], p[1] - 1); > > + *vc_fac_mask |= X25_MASK_CALLING_AE; > > + break; > > Can this '33' magic number be replaced with a define or sizeof(something)? > > - Arnaldo
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |