Messages in this thread | | | Date | Wed, 15 Feb 2006 20:35:37 -0200 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 5/6] x25: Allow 32 bit socket ioctl in 64 bit kernel |
| |
On 2/15/06, Shaun Pereira <spereira@tusc.com.au> wrote:
> + switch (*p) { > + case X25_FAC_CALLING_AE: > + if (p[1] > 33) > + break; > + dte_facs->calling_len = p[2]; > + memcpy(dte_facs->calling_ae, &p[3], p[1] - 1); > + *vc_fac_mask |= X25_MASK_CALLING_AE; > + break;
Can this '33' magic number be replaced with a define or sizeof(something)?
- Arnaldo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |