lkml.org 
[lkml]   [2006]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] sched: remove on runqueue requeueing
Date
Andrew please apply. Thanks Mike.

Cheers,
Con
---
On runqueue time is used to elevate priority in schedule().

In the code it currently requeues tasks even if their priority is not
elevated, which would end up placing them at the end of their runqueue
array effectively delaying them instead of improving their priority.

Bug spotted by Mike Galbraith <efault@gmx.de>

This patch removes this requeueing.

Signed-off-by: Con Kolivas <kernel@kolivas.org>

kernel/sched.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)

Index: linux-2.6.16-rc3-mm1/kernel/sched.c
===================================================================
--- linux-2.6.16-rc3-mm1.orig/kernel/sched.c 2006-02-15 22:29:15.000000000 +1100
+++ linux-2.6.16-rc3-mm1/kernel/sched.c 2006-02-15 22:32:20.000000000 +1100
@@ -3107,8 +3107,7 @@ go_idle:
dequeue_task(next, array);
next->prio = new_prio;
enqueue_task(next, array);
- } else
- requeue_task(next, array);
+ }
}
next->sleep_type = SLEEP_NORMAL;
switch_tasks:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2006-02-15 12:44    [W:0.033 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site