Messages in this thread Patch in this message | | | Date | Fri, 10 Feb 2006 23:21:46 +0900 | From | Yasunori Goto <> | Subject | [RFC/PATCH: 010/010] Memory hotplug for new nodes with pgdat allocation.(allow -EEXIST of add_memory) |
| |
When acpi_memory_device_init() is called at boottime to register struct memory acpi_memory_device. So, acpi_bus_add() are called via acpi_driver_attach(). But it also calls ops->start() function. It is called even if the memory blocks are initialized at early boottime. In this case add_memory() return -EEXIST, and the memory blocks becomes INVALID state even if it is normal.
This is patch for it.
Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
Index: pgdat2/drivers/acpi/acpi_memhotplug.c =================================================================== --- pgdat2.orig/drivers/acpi/acpi_memhotplug.c 2006-02-10 15:35:34.000000000 +0900 +++ pgdat2/drivers/acpi/acpi_memhotplug.c 2006-02-10 15:35:36.000000000 +0900 @@ -201,8 +201,18 @@ static int acpi_memory_enable_device(str * Note: Assume that this function returns zero on success */ result = add_memory(mem_device->start_addr, mem_device->length); - if (result) { - ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "\nadd_memory failed\n")); + switch(result) { + case 0: + break; + case -EEXIST: + ACPI_DEBUG_PRINT((ACPI_DB_INFO, + "\nmemory start=%lu size=%lu has already existed\n", + mem_device->start_addr, + mem_device->length)); + return 0; + default: + ACPI_DEBUG_PRINT((ACPI_DB_ERROR, + "\nadd_memory failed result=%d\n", result)); mem_device->state = MEMORY_INVALID_STATE; return result; } -- Yasunori Goto
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |