Messages in this thread | | | From | Nigel Cunningham <> | Subject | Re: [ 01/10] [Suspend2] kernel/power/modules.h' | Date | Thu, 2 Feb 2006 07:31:53 +1000 |
| |
Hi.
On Thursday 02 February 2006 03:12, Randy.Dunlap wrote: > On Wed, 1 Feb 2006, Nigel Cunningham wrote: > > On Wednesday 01 February 2006 22:32, Pekka Enberg wrote: > > > On 2/1/06, Nigel Cunningham <nigel@suspend2.net> wrote: > > > > Suspend2 uses a strong internal API to separate the method of > > > > determining the content of the image from the method by which it is > > > > saved. The code for determining the content is part of the core of > > > > Suspend2, and transformations (compression and/or encryption) and > > > > storage of the pages are handled by 'modules'. > > > > > > [snip] > > > > > > > Signed-off-by: Nigel Cunningham <nigel@suspend2.net> > > > > > > > > 0 files changed, 0 insertions(+), 0 deletions(-) > > > > > > Uh, oh, where's the patch? > > > > Indeed! Oops! I think I've managed to put this in kmail without having it > > mangled! > > > > Nigel > > > > > > [Suspend2] kernel/power/modules.h > > > > kernel/power/modules.h | 179 > > ++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 179 > > insertions(+), 0 deletions(-) > > > > diff --git a/kernel/power/modules.h b/kernel/power/modules.h > > new file mode 100644 > > index 0000000..ee34199 > > --- /dev/null > > +++ b/kernel/power/modules.h > > @@ -0,0 +1,179 @@ > > +/* > > + * kernel/power/module.h > > wrong file name.
Oops. Thanks.
> > +enum { > > + FILTER_PLUGIN, > > + WRITER_PLUGIN, > > + MISC_PLUGIN, // Block writer, eg. > > + CHECKSUM_PLUGIN > > +}; > > Kernel comment style is /* ... */, not // (many places).
Hmm. Learnt that a while ago. Not sure how I missed this one :)
> > + /* Bytes! */ > > Drop the '!'.
:) Will do.
Nigel
-- See our web page for Howtos, FAQs, the Wiki and mailing list info. http://www.suspend2.net IRC: #suspend2 on Freenode [unhandled content-type:application/pgp-signature] | |