Messages in this thread Patch in this message | | | Date | Sat, 9 Dec 2006 00:36:35 -0800 | From | Randy Dunlap <> | Subject | [PATCH] ucb1400_ts depends SND_AC97_BUS |
| |
From: Randy Dunlap <randy.dunlap@oracle.com>
This driver is an AC97 codec according to its help text. However, if SOUND is disabled, the "select SND_AC97_BUS" still inserts that into the .config file:
# # Sound # # CONFIG_SOUND is not set CONFIG_SND_AC97_BUS=m
Even if the config software followed dependency chains on selects, we should try to limit usage of "select" to library-type code that is needed (e.g., CRC functions) instead of bus-type support.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- drivers/input/touchscreen/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.19-git13.orig/drivers/input/touchscreen/Kconfig +++ linux-2.6.19-git13/drivers/input/touchscreen/Kconfig @@ -146,7 +146,7 @@ config TOUCHSCREEN_TOUCHWIN config TOUCHSCREEN_UCB1400 tristate "Philips UCB1400 touchscreen" - select SND_AC97_BUS + depends on SND_AC97_BUS help This enables support for the Philips UCB1400 touchscreen interface. The UCB1400 is an AC97 audio codec. The touchscreen interface
--- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |