lkml.org 
[lkml]   [2006]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH] drivers/usb/core/message.c: Replacing yield() with a better alternative
From
Date
In 2.6, the semantics of calling yield() changed from "sleep for a
bit" to "I really don't want to run for a while". This matches POSIX
better, but there's a lot of drivers still using yield() when they mean
cond_resched(), schedule() or even schedule_timeout().

For this driver cond_resched() seems to be a better
alternative

Tested compile only

Signed-off-by: Amol Lad <amol@verismonetworks.com>
---
diff -uprN -X linux-2.6.19-rc1-orig/Documentation/dontdiff linux-2.6.19-rc1-orig/drivers/usb/core/message.c linux-2.6.19-rc1/drivers/usb/core/message.c
--- linux-2.6.19-rc1-orig/drivers/usb/core/message.c 2006-10-05 14:00:52.000000000 +0530
+++ linux-2.6.19-rc1/drivers/usb/core/message.c 2006-10-11 17:57:02.000000000 +0530
@@ -502,7 +502,7 @@ void usb_sg_wait (struct usb_sg_request
io->urbs[i]->dev = NULL;
retval = 0;
i--;
- yield ();
+ cond_resched();
break;

/* no error? continue immediately.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-11 14:55    [W:0.027 / U:1.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site