Messages in this thread Patch in this message | | | Date | Tue, 10 Oct 2006 03:32:15 -0400 | From | Jeff Garzik <> | Subject | [PATCH] atm/firestream: handle thrown error |
| |
gcc emits the following warning:
drivers/atm/firestream.c: In function ‘fs_open’: drivers/atm/firestream.c:870: warning: ‘tmc0’ may be used uninitialized in this function
This indicates a real bug. We should check make_rate() return value for potential errors.
Signed-off-by: Jeff Garzik <jeff@garzik.org>
---
drivers/atm/firestream.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c index 40ab9b6..697ad82 100644 --- a/drivers/atm/firestream.c +++ b/drivers/atm/firestream.c @@ -1002,6 +1002,10 @@ static int fs_open(struct atm_vcc *atm_v r = ROUND_UP; } error = make_rate (pcr, r, &tmc0, NULL); + if (error) { + kfree(tc); + return error; + } } fs_dprintk (FS_DEBUG_OPEN, "pcr = %d.\n", pcr); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |