Messages in this thread Patch in this message | | | Date | Tue, 10 Oct 2006 03:03:34 -0400 | From | Jeff Garzik <> | Subject | [PATCH] x86/microcode: handle sysfs errors |
| |
Signed-off-by: Jeff Garzik <jeff@garzik.org>
---
Note that the driver code API must be fixed to actually check the return code of the ->add() hook, for this patch to be of any real use.
arch/i386/kernel/microcode.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
a95aa9d762b6571bf52b50e47b4d2793eb649b1c diff --git a/arch/i386/kernel/microcode.c b/arch/i386/kernel/microcode.c index bca92be..441f140 100644 --- a/arch/i386/kernel/microcode.c +++ b/arch/i386/kernel/microcode.c @@ -656,14 +656,18 @@ static struct attribute_group mc_attr_gr static int mc_sysdev_add(struct sys_device *sys_dev) { - int cpu = sys_dev->id; + int err, cpu = sys_dev->id; struct ucode_cpu_info *uci = ucode_cpu_info + cpu; if (!cpu_online(cpu)) return 0; + pr_debug("Microcode:CPU %d added\n", cpu); memset(uci, 0, sizeof(*uci)); - sysfs_create_group(&sys_dev->kobj, &mc_attr_group); + + err = sysfs_create_group(&sys_dev->kobj, &mc_attr_group); + if (err) + return err; microcode_init_cpu(cpu); return 0; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |