Messages in this thread Patch in this message | | | Subject | RE: [Cbe-oss-dev] [PATCH 09/14] spufs: add support for read/write oncntl | Date | Tue, 10 Oct 2006 15:49:08 +0900 | From | "Noguchi, Masato" <> |
| |
Oops, I'm so sorry. I mistake to send wrong patch. Correct version is below:
Signed-off-by: Masato Noguchi <Masato.Noguchi@jp.sony.com>
---
Index: linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c =================================================================== --- linux-2.6.18-arnd-20061004.orig/arch/powerpc/platforms/cell/spufs/file.c +++ linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c @@ -246,6 +246,7 @@ static int spufs_cntl_open(struct inode
static struct file_operations spufs_cntl_fops = { .open = spufs_cntl_open, + .release = simple_attr_close, .read = simple_attr_read, .write = simple_attr_write, .mmap = spufs_cntl_mmap,
> -----Original Message----- > From: Noguchi, Masato > Sent: Tuesday, October 10, 2006 3:00 PM > To: 'Arnd Bergmann' > Cc: Paul Mackerras; Arnd Bergmann; linuxppc-dev@ozlabs.org; > cbe-oss-dev@ozlabs.org; linux-kernel@vger.kernel.org > Subject: RE: [Cbe-oss-dev] [PATCH 09/14] spufs: add support for read/write > oncntl > > After applying these patches, it seems the kernel leaks memory. > No doubt you forget to call simple_attr_close on "[PATCH 09/14] > spufs: add support for read/write oncntl". > > Signed-off-by: Masato Noguchi <Masato.Noguchi@jp.sony.com> > > --- > > Index: linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c > =================================================================== > --- > linux-2.6.18-arnd-20061004.orig/arch/powerpc/platforms/cell/spufs/file.c > +++ linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c > @@ -246,6 +246,7 @@ static int spufs_cntl_open(struct inode > > static struct file_operations spufs_cntl_fops = { > .open = spufs_cntl_open, > + .close = simple_attr_close, > .read = simple_attr_read, > .write = simple_attr_write, > .mmap = spufs_cntl_mmap, >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |