Messages in this thread Patch in this message | | | Subject | [PATCH] exec: Only allow a threaded init to exec from the thread_group_leader | From | (Eric W. Biederman) | Date | Sat, 28 Jan 2006 23:18:57 -0700 |
| |
The weird things we do when we exec from a thread group are just ugly. Those ugly things do not handle the case of init and I suspect extending that code to properly support a threaded init would be just hideous, and impossible to maintain.
So just in case someone ever threads init return an error for the unimplemented case.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
fs/exec.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
408dad0f2b7067b23929866150e73b2b2f12d662 diff --git a/fs/exec.c b/fs/exec.c index 055378d..c9d8e31 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -600,6 +600,12 @@ static int de_thread(struct task_struct if (thread_group_empty(current)) goto no_thread_group; + /* A threaded init must exec from it's primary thread. + * As the init task (i.e. child_reaper) may not exit. + */ + if (!thread_group_leader(current) && (current->tgid == 1)) + return -EINVAL; + /* * Kill all other threads in the thread group. * We must hold tasklist_lock to call zap_other_threads. -- 1.1.5.g3480 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |