lkml.org 
[lkml]   [2005]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] rio: switch to ANSI prototypes
On Thu, Sep 29, 2005 at 04:25:56PM +0100, Al Viro wrote:
> Uh-oh... Well, if you want to play with it... FWIW, I'm disabling rio as
> hopeless FPOS; if you feel masochistic, go ahead but keep in mind that its
> handling of tty glue is severely b0rken.

Well, duh... It clutters _my_ logs.

> > int
> > -RIOBootCodeHOST(p, rbp)
> > -struct rio_info * p;
> > -register struct DownLoad *rbp;
> > +RIOBootCodeHOST(struct rio_info *p, register struct DownLoad *rbp)
>
> s/register//

Sure.

> > int
> > -riocontrol(p, dev, cmd, arg, su)
> > -struct rio_info * p;
> > -dev_t dev;
> > -int cmd;
> > -caddr_t arg;
> > -int su;
> > +riocontrol(struct rio_info *p, dev_t dev, int cmd, caddr_t arg, int su)
>
> Use of dev_t here is almost certainly broken.

It is with the only call being

drivers/char/rio/rio_linux.c:
642 /* The "dev" argument isn't used. */
643 rc = riocontrol (p, 0, cmd, (void *)arg, capable(CAP_SYS_ADMIN));

Though riocontrol() happily does MAJOR(dev) three times.

> Use of caddr_t is *always* broken.

"unsigned long arg" or do you keep in mind something more fundamental?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-09-29 18:44    [W:0.058 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site