Messages in this thread Patch in this message | | | Date | Thu, 29 Sep 2005 16:25:56 +0100 | From | Al Viro <> | Subject | Re: [PATCH] rio: switch to ANSI prototypes |
| |
On Thu, Sep 29, 2005 at 07:22:08PM +0400, Alexey Dobriyan wrote: > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> > --- > > drivers/char/rio/rioboot.c | 25 +++++-------------------- > drivers/char/rio/rioctrl.c | 12 ++---------- > drivers/char/rio/rioinit.c | 27 +++++---------------------- > drivers/char/rio/riointr.c | 12 +++--------- > drivers/char/rio/rioparam.c | 24 ++++++------------------ > drivers/char/rio/rioroute.c | 34 +++++++--------------------------- > drivers/char/rio/riotable.c | 19 +++++-------------- > drivers/char/rio/riotty.c | 3 +-- > 8 files changed, 34 insertions(+), 122 deletions(-)
Uh-oh... Well, if you want to play with it... FWIW, I'm disabling rio as hopeless FPOS; if you feel masochistic, go ahead but keep in mind that its handling of tty glue is severely b0rken.
> int > -RIOBootCodeHOST(p, rbp) > -struct rio_info * p; > -register struct DownLoad *rbp; > +RIOBootCodeHOST(struct rio_info *p, register struct DownLoad *rbp)
s/register//
> @@ -151,12 +151,7 @@ static int copyout (caddr_t dp, int arg, > } > > int > -riocontrol(p, dev, cmd, arg, su) > -struct rio_info * p; > -dev_t dev; > -int cmd; > -caddr_t arg; > -int su; > +riocontrol(struct rio_info *p, dev_t dev, int cmd, caddr_t arg, int su)
Use of dev_t here is almost certainly broken. Use of caddr_t is *always* broken. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |