Messages in this thread | | | Date | Thu, 29 Sep 2005 02:10:26 +0100 | From | Al Viro <> | Subject | Re: [PATCH] remove check_region in drivers-char-specialix.c |
| |
On Thu, Sep 29, 2005 at 12:28:22AM +0200, Borislav Petkov wrote: > Andrew told me already today that Jeff[1] had sent a patch fixing all that. To > prevent the leaks he's calling sx_release_io_range(bp) in every check before > exiting sx_probe so this seems correct. A small question though: After calling > sx_request_io_range() in the if-statement on line 499 is it ok to call > sx_request_io_range() for a second time in a row on line 587? I think in > this case the second call has to go, no? > > [1]rsync://rsync.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git
Huh? I don't see any specialix patches in that repository right now...
But yes, after successful request_region() you shouldn't call it again - that would simply fail. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |