Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 28 Sep 2005 18:52:44 +0100 | From | Al Viro <> | Subject | Re: [PATCH] remove check_region in drivers-char-specialix.c |
| |
On Wed, Sep 28, 2005 at 10:37:37AM +0200, Borislav Petkov wrote: > Hi Andrew, > > This is also a pretty simple case. We remove the wrapper and make > sx__request_io_range return struct resource *. We check its value accordingly > in the probing routine. It compiles cleanly here.
NAK. You've just introduced a pile of leaks - if sx_probe() fails after that call, you end up with region claimed and not released. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |