Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Sun, 31 Jul 2005 13:12:08 +0200 | From | domen@coderock ... | Subject | [patch 3/5] Driver core: Documentation: use snprintf and strnlen |
| |
From: Jan Veldeman <jan@mind.be>
Documentation should give the good example of using snprintf and strnlen in stead of sprintf and strlen.
PAGE_SIZE is used as the maximal length to reflect the behaviour of show/store.
Signed-off-by: Jan Veldeman <Jan.Veldeman@advalvas.be> Signed-off-by: Domen Puncer <domen@coderock.org>
--- sysfs.txt | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
Index: quilt/Documentation/filesystems/sysfs.txt =================================================================== --- quilt.orig/Documentation/filesystems/sysfs.txt +++ quilt/Documentation/filesystems/sysfs.txt @@ -216,13 +216,13 @@ A very simple (and naive) implementation static ssize_t show_name(struct device *dev, struct device_attribute *attr, char *buf) { - return sprintf(buf,"%s\n",dev->name); + return snprintf(buf,PAGE_SIZE,"%s\n",dev->name); } static ssize_t store_name(struct device * dev, const char * buf) { sscanf(buf,"%20s",dev->name); - return strlen(buf); + return strnlen(buf,PAGE_SIZE); } static DEVICE_ATTR(name,S_IRUGO,show_name,store_name); -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |