Messages in this thread Patch in this message | | | Subject | [patch 132/198] quota: possible bug in quota format v2 support | From | akpm@osdl ... | Date | Tue, 12 Apr 2005 03:32:39 -0700 |
| |
From: Niu YaWei <niu@clusterfs.com>
Don't put root block of quota tree to the free list (when quota file is completely empty). That should not actually happen anyway (somebody should get accounted for the filesystem root and so quota file should never be empty) but better prevent it here than solve magical quota file corruption.
Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Andrew Morton <akpm@osdl.org> ---
25-akpm/fs/quota_v2.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletion(-)
diff -puN fs/quota_v2.c~quota-possible-bug-in-quota-format-v2-support fs/quota_v2.c --- 25/fs/quota_v2.c~quota-possible-bug-in-quota-format-v2-support 2005-04-12 03:21:35.447748024 -0700 +++ 25-akpm/fs/quota_v2.c 2005-04-12 03:21:35.450747568 -0700 @@ -503,7 +503,8 @@ static int remove_tree(struct dquot *dqu int i; ref[GETIDINDEX(dquot->dq_id, depth)] = cpu_to_le32(0); for (i = 0; i < V2_DQBLKSIZE && !buf[i]; i++); /* Block got empty? */ - if (i == V2_DQBLKSIZE) { + /* Don't put the root block into the free block list */ + if (i == V2_DQBLKSIZE && *blk != V2_DQTREEOFF) { put_free_dqblk(sb, type, buf, *blk); *blk = 0; } _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |