Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Subject | [patch 161/198] IB: Fix user MAD registrations with class 0 | From | akpm@osdl ... | Date | Tue, 12 Apr 2005 03:33:05 -0700 |
| |
From: Roland Dreier <roland@topspin.com>
Fix handling of MAD agent registrations with mgmt_class == 0. In this case ib_umad should pass a NULL registration request to the MAD core rather than a request with mgmt_class set to 0.
Signed-off-by: Roland Dreier <roland@topspin.com> Signed-off-by: Andrew Morton <akpm@osdl.org> ---
25-akpm/drivers/infiniband/core/user_mad.c | 14 ++++++++------ 1 files changed, 8 insertions(+), 6 deletions(-)
diff -puN drivers/infiniband/core/user_mad.c~ib-fix-user-mad-registrations-with-class-0 drivers/infiniband/core/user_mad.c --- 25/drivers/infiniband/core/user_mad.c~ib-fix-user-mad-registrations-with-class-0 2005-04-12 03:21:41.957758352 -0700 +++ 25-akpm/drivers/infiniband/core/user_mad.c 2005-04-12 03:21:41.960757896 -0700 @@ -389,15 +389,17 @@ static int ib_umad_reg_agent(struct ib_u goto out; found: - req.mgmt_class = ureq.mgmt_class; - req.mgmt_class_version = ureq.mgmt_class_version; - memcpy(req.method_mask, ureq.method_mask, sizeof req.method_mask); - memcpy(req.oui, ureq.oui, sizeof req.oui); + if (ureq.mgmt_class) { + req.mgmt_class = ureq.mgmt_class; + req.mgmt_class_version = ureq.mgmt_class_version; + memcpy(req.method_mask, ureq.method_mask, sizeof req.method_mask); + memcpy(req.oui, ureq.oui, sizeof req.oui); + } agent = ib_register_mad_agent(file->port->ib_dev, file->port->port_num, ureq.qpn ? IB_QPT_GSI : IB_QPT_SMI, - &req, 0, send_handler, recv_handler, - file); + ureq.mgmt_class ? &req : NULL, + 0, send_handler, recv_handler, file); if (IS_ERR(agent)) { ret = PTR_ERR(agent); goto out; _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |