lkml.org 
[lkml]   [2005]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Subjectle conversion of posix acl fields
From
Date
I saw your patch referenced in 
http://marc.theaimsgroup.com/?l=linux-kernel&m=110859724430665&w=2

At first glance there is one odd place in the proposed patch:

- cifs_ace->cifs_e_perm = (__u8)cpu_to_le16(local_ace->e_perm);
- cifs_ace->cifs_e_tag = (__u8)cpu_to_le16(local_ace->e_tag);
+ cifs_ace->cifs_e_perm = (__u8)le16_to_cpu(local_ace->e_perm);
+ cifs_ace->cifs_e_tag = (__u8)le16_to_cpu(local_ace->e_tag);

If the field is le already then we should not convert it to cpu (since
cifs protocol assumes le format on the wire - it probably needs no
endian conversion in these two lines unless I am missing something)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:10    [W:0.025 / U:1.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site