Messages in this thread | | | Subject | Re: make flock_lock_file_wait static | From | Arjan van de Ven <> | Date | Mon, 10 Jan 2005 09:44:33 +0100 |
| |
On Mon, 2005-01-10 at 02:35 -0600, Ken Preslan wrote: > On Sun, Jan 09, 2005 at 05:44:10PM -0500, Trond Myklebust wrote: > > su den 09.01.2005 Klokka 19:42 (+0000) skreiv Arjan van de Ven: > > > Hi, > > > > > > the patch below makes flock_lock_file_wait static, because it is only used > > > (once) in fs/locks.c. Making it static allows gcc to generate better code > > > (partial or entirely inlining it, gcc 3.4 also optimizes the calling > > > convention for static functions which are guaranteed only local to the file) > > > > Veto. That function is also there for those filesystems that need to > > mirror their locks in the VFS. I believe the GFS people are already > > using it (they implemented all this anyway), and sooner or later, NFS is > > going to have to do it too... > > I second the veto. GFS does use this interface. >
when are you going to propose GFS for inclusion? Is that next week or is that months out? Is that really worth bloating everyones kernel until then ?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |