Messages in this thread | | | Subject | Re: make flock_lock_file_wait static | From | Arjan van de Ven <> | Date | Mon, 10 Jan 2005 09:38:44 +0100 |
| |
On Mon, 2005-01-10 at 09:19 +0100, Arjan van de Ven wrote: > On Sun, 2005-01-09 at 17:44 -0500, Trond Myklebust wrote: > > su den 09.01.2005 Klokka 19:42 (+0000) skreiv Arjan van de Ven: > > > Hi, > > > > > > the patch below makes flock_lock_file_wait static, because it is only used > > > (once) in fs/locks.c. Making it static allows gcc to generate better code > > > (partial or entirely inlining it, gcc 3.4 also optimizes the calling > > > convention for static functions which are guaranteed only local to the file) > > > > Veto. That function is also there for those filesystems that need to > > mirror their locks in the VFS. I believe the GFS people are already > > using it (they implemented all this anyway), and sooner or later, NFS is > > going to have to do it too... > > before > # size fs/locks.o > text data bss dec hex filename > 14712 48 4 14764 39ac fs/locks.o > > after (with static inline) > # size fs/locks.o > text data bss dec hex filename > 14648 48 4 14700 396c fs/locks.o > > > is "sooner or later" and "maybe someone else uses it" worth making > everyone elses kernel bigger by 500 bytes of code ?
eh 60 not 500; sorry need coffee
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |