Messages in this thread Patch in this message | | | Date | Fri, 23 Jul 2004 17:55:28 +0200 | From | maximilian attems <> | Subject | [patch-kj] use list_for_each() in fs/jffs/intrep.c |
| |
Use list_for_each() where applicable - for (list = ymf_devs.next; list != &ymf_devs; list = list->next) { + list_for_each(list, &ymf_devs) { pure cosmetic change, defined as a preprocessor macro in: include/linux/list.h
applies cleanly to 2.6.8-rc2
From: Domen Puncer <domen@coderock.org> Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
---
linux-2.6.7-bk20-max/fs/jffs/intrep.c | 13 ++++++------- 1 files changed, 6 insertions(+), 7 deletions(-)
diff -puN fs/jffs/intrep.c~list_for_each-fs-jffs fs/jffs/intrep.c --- linux-2.6.7-bk20/fs/jffs/intrep.c~list_for_each-fs-jffs 2004-07-11 14:41:04.000000000 +0200 +++ linux-2.6.7-bk20-max/fs/jffs/intrep.c 2004-07-11 14:41:04.000000000 +0200 @@ -1623,7 +1623,7 @@ jffs_find_file(struct jffs_control *c, _ D3(printk("jffs_find_file(): ino: %u\n", ino)); - for (tmp = c->hash[i].next; tmp != &c->hash[i]; tmp = tmp->next) { + list_for_each(tmp, &c->hash[i]) { f = list_entry(tmp, struct jffs_file, hash); if (ino != f->ino) continue; @@ -2021,11 +2021,10 @@ jffs_foreach_file(struct jffs_control *c for (pos = 0; pos < c->hash_len; pos++) { struct list_head *p, *next; - for (p = c->hash[pos].next; p != &c->hash[pos]; p = next) { - /* We need a reference to the next file in the - list because `func' might remove the current - file `f'. */ - next = p->next; + + /* We must do _safe, because 'func' might remove the + current file 'f' from the list. */ + list_for_each_safe(p, next, &c->hash[pos]) { r = func(list_entry(p, struct jffs_file, hash)); if (r < 0) return r; @@ -2590,7 +2589,7 @@ jffs_print_hash_table(struct jffs_contro printk("JFFS: Dumping the file system's hash table...\n"); for (i = 0; i < c->hash_len; i++) { struct list_head *p; - for (p = c->hash[i].next; p != &c->hash[i]; p = p->next) { + list_for_each(p, &c->hash[i]) { struct jffs_file *f=list_entry(p,struct jffs_file,hash); printk("*** c->hash[%u]: \"%s\" " "(ino: %u, pino: %u)\n", - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |