Messages in this thread | | | Date | Sun, 13 Jun 2004 08:07:57 +1000 | From | Nigel Cunningham <> | Subject | Re: Fix memory leak in swsusp |
| |
Hi.
Andrew Morton wrote: > Nigel Cunningham <ncunningham@linuxmail.org> wrote: > >> We were avoiding the use of memcpy because it messes up the preempt count with 3DNow, and >> potentially as other unseen side effects. The preempt could possibly simply be reset at resume time, >> but the point remains. > > > eh? memcpy just copies memory. Maybe your meant copy_*_user()?
At some stage, you copy the page that contains the preempt count for the process that is doing the suspending. If you use memcpy on a 3Dnow machine, the preempt count is incremented prior to doing the copy of the page. Then, at resume time, it is one too high.
Regards,
Nigel -- Nigel & Michelle Cunningham C/- Westminster Presbyterian Church Belconnen 61 Templeton Street, Cook, ACT 2614. +61 (417) 100 574 (mobile) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |