Messages in this thread Patch in this message | | | Date | Fri, 7 May 2004 13:14:02 +0200 | From | Romain Lievin <> | Subject | [PATCH 2.4] tipar char driver: wront timeout value |
| |
Hi,
this patch fixes a bug on the timeout value. The formula used to calculate jiffies from timeout was wrong. The new formula is ok and takes care of integer computation/rounding.
This bug has already been fixed in the 2.6 kernel.
Please apply, Romain.
=============[ cut here ]=============== diff -Naur linux-2.4.26.orig/drivers/char/tipar.c linux-2.4.26/drivers/char/tipar.c --- linux-2.4.26.orig/drivers/char/tipar.c 2004-02-18 14:36:31.000000000 +0100 +++ linux-2.4.26/drivers/char/tipar.c 2004-04-19 09:22:36.000000000 +0200 @@ -124,7 +124,7 @@ /* ----- global defines ----------------------------------------------- */ -#define START(x) { x=jiffies+HZ/(timeout/10); } +#define START(x) { x = jiffies + (HZ * timeout) / 10; } #define WAIT(x) { \ if (time_before((x), jiffies)) return -1; \ if (need_resched()) schedule(); } -- Romain Liévin : <roms@lievin.net> Web site : http://www.lievin.net "Linux, y'a moins bien mais c'est plus cher !"
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |