Messages in this thread | | | Date | Mon, 24 May 2004 17:36:16 +1000 | From | Stephen Rothwell <> | Subject | Re: [PATCH] dynamic addition of virtual disks on PPC64 iSeries |
| |
On Mon, 24 May 2004 00:23:28 -0700 Dave Hansen <haveblue@us.ibm.com> wrote: > > On Mon, 2004-05-24 at 00:05, Stephen Rothwell wrote: > > On Sun, 23 May 2004 23:29:20 -0700 Andrew Morton <akpm@osdl.org> wrote: > > > Or to generate a hotplug event when a disk is added? Even if there's no > > > notification to the kernel, it should be possible to generate the hotplug > > > events in response to a /proc-based trigger. > > > > I guess that would be possible. In this case I am trying to do the > > minimum change. > > I think this would be a worthy change. It's the same kind of thing that > we're planning for memory hotplug on ppc64: initiate a probe in /sys > somewhere, and get a few hotplug events in short order. The only > difference is that we'll probably require a write for the probe to > trigger. You don't want a 'grep -r foo /sys' to cause probes, do you?
OK, I am convinced. :-) Now to learn about hotplug. :-(
> > + printk(VIOD_KERN_INFO "disk %d: %lu sectors (%lu MB) " > > + "CHS=%d/%d/%d sector size %d%s\n", > > + dev_no, (unsigned long)(d->size >> 9), > > + (unsigned long)(d->size >> 20), > > + (int)d->cylinders, (int)d->tracks, > > + (int)d->sectors, (int)d->bytes_per_sector, > > + d->read_only ? " (RO)" : ""); > > + > > Isn't it a little naughty to be spitting out so many values in a /sys > file?
Thats not the sys file ...
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [unhandled content-type:application/pgp-signature] | |