Messages in this thread | | | Subject | Re: [PATCH] dynamic addition of virtual disks on PPC64 iSeries | From | Dave Hansen <> | Date | Mon, 24 May 2004 00:23:28 -0700 |
| |
On Mon, 2004-05-24 at 00:05, Stephen Rothwell wrote: > On Sun, 23 May 2004 23:29:20 -0700 Andrew Morton <akpm@osdl.org> wrote: > > Or to generate a hotplug event when a disk is added? Even if there's no > > notification to the kernel, it should be possible to generate the hotplug > > events in response to a /proc-based trigger. > > I guess that would be possible. In this case I am trying to do the > minimum change.
I think this would be a worthy change. It's the same kind of thing that we're planning for memory hotplug on ppc64: initiate a probe in /sys somewhere, and get a few hotplug events in short order. The only difference is that we'll probably require a write for the probe to trigger. You don't want a 'grep -r foo /sys' to cause probes, do you?
> + printk(VIOD_KERN_INFO "disk %d: %lu sectors (%lu MB) " > + "CHS=%d/%d/%d sector size %d%s\n", > + dev_no, (unsigned long)(d->size >> 9), > + (unsigned long)(d->size >> 20), > + (int)d->cylinders, (int)d->tracks, > + (int)d->sectors, (int)d->bytes_per_sector, > + d->read_only ? " (RO)" : ""); > +
Isn't it a little naughty to be spitting out so many values in a /sys file?
-- Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |