Messages in this thread | | | From | (Thomas Gleixner) | Subject | Re: [RFD] Explicitly documenting patch submission | Date | Mon, 24 May 2004 22:50:38 +0200 |
| |
On Monday 24 May 2004 21:57, Andi Kleen wrote: > Linus Torvalds <torvalds@osdl.org> writes: > > Hola! > > This is a request for discussion..
> e.g. normally the maintainer would just answer "ok, looks good, > applied". Now they would need to ask "ok, did you write this. if not > through which hands did it pass"? and wait for a reply and then only > add the patch when you know whom to put into all these Signed-off-by > lines.
What I'm missing in this discussion is a clear distinction between patches and contributions.
A patch is usually a more or less small fix / improvement of existing code and should be treated accordingly. Recording "signed-off" chains for those would just using up repository space and could be used just for another type of useless statistics.
Contributions are larger pieces of code introducing new functionalities or algorithms and contain probably stuff which could be classified as "Intellectual Property" and therefor Linus' proposal is surely appropriate.
I'm not sure how to distinguish exactly between patches and contributions, but I'm not convinced, that
- (if x > 0) + (if x >= 0) signed-off hacker signed-off module-maintainer signed-off subsystem-maintainer signed-off linus / andrea /...
would really be helpful and desired.
> This is not unrealistic, For example for patches that are "official > projects" by someone it often happens that not the actual submitter > sends the patch, but his manager (often not even cc'ing the original > developer). ....
If the manager or who ever ensures by signing off that this code is according to the submission rules, then it should be sufficient for the maintainer.
-- Thomas ________________________________________________________________________ Steve Ballmer quotes the statistic that IT pros spend 70 percent of their time managing existing systems. That couldn’t have anything to do with the fact that 99 percent of these systems run Windows, could it? ________________________________________________________________________ linutronix - competence in embedded & realtime linux http://www.linutronix.de mail: tglx@linutronix.de
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |